Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-2271: Document additional cp-demo troubleshooting steps #297

Merged
merged 8 commits into from
Dec 3, 2020

Conversation

ybyzek
Copy link
Contributor

@ybyzek ybyzek commented Dec 3, 2020

Description

https://confluentinc.atlassian.net/browse/DEVX-2271

What behavior does this PR change, and why?

  1. Enable users to take additional troubleshooting steps on their own
  2. Improve readability with .. code-block:: JSON

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

  • Documentation (local build passes)

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

docs/index.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated
@@ -280,7 +284,7 @@ Its embedded producer is configured to be idempotent, exactly-once in order sema
.. figure:: images/ksql_properties.png
:alt: image

#. This example creates two streams ``EN_WIKIPEDIA_GT_1`` and ``EN_WIKIPEDIA_GT_1_COUNTS``, and the reason is to demonstrate how ksqlDB windows work. ``EN_WIKIPEDIA_GT_1`` counts occurences with a tumbling window, and for a given key it writes a `null` into the table on the first seen message. The underlying Kafka topic for ``EN_WIKIPEDIA_GT_1`` does not filter out those nulls, but to send just the counts greater than one downstream, there is a separate Kafka topic for ``EN_WIKIPEDIA_GT_1_COUNTS`` which does filter out those nulls (e.g., the query has a clause ``where ROWTIME is not null``). From the bash prompt, view those underlying Kafka topics.
#. This example creates two streams ``EN_WIKIPEDIA_GT_1`` and ``EN_WIKIPEDIA_GT_1_COUNTS``, and the reason is to demonstrate how ksqlDB windows work. ``EN_WIKIPEDIA_GT_1`` counts occurrences with a tumbling window, and for a given key it writes a `null` into the table on the first seen message. The underlying Kafka topic for ``EN_WIKIPEDIA_GT_1`` does not filter out those nulls, but to send just the counts greater than one downstream, there is a separate Kafka topic for ``EN_WIKIPEDIA_GT_1_COUNTS`` which does filter out those nulls (e.g., the query has a clause ``where ROWTIME is not null``). From the bash prompt, view those underlying Kafka topics.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EN_WIKIPEDIA_GT_1 is a topic name. EN_WIKIPEDIA_GT_1_STREAM is the stream name.

The where rowtime is not null condition is somewhat confusing, because the null-valued records actually have a timestamp. It's the fact that there's a where clause that causes the null-valued records to be silently dropped: confluentinc/ksql#5634

By the way, this behavior will likely be changing in ksqlDB 6.1.0: confluentinc/ksql#3558

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikebin 👍 thank you for surfacing this and flagging the potential behavior change. Since this PR is for troubleshooting steps (and spelling errors), I filed https://confluentinc.atlassian.net/browse/DEVX-2298 to track the issue separately.

@ybyzek ybyzek changed the title DEVX-2271: Documentation additional cp-demo troubleshooting steps DEVX-2271: Document additional cp-demo troubleshooting steps Dec 3, 2020
@ybyzek ybyzek merged commit d1c4f48 into 6.0.1-post Dec 3, 2020
@ybyzek ybyzek deleted the DEVX-2271 branch December 3, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants