Skip to content

Commit

Permalink
feat: enable max/min udaf for string & bytes data types
Browse files Browse the repository at this point in the history
- The max and min udaf was generalized to handle date & time data types
  See - 5134393
- As a result, the code was capable of supporting string and bytes data types
- This commit simply enables them in the max and min udaf's
  • Loading branch information
bvarghese1 committed Apr 28, 2022
1 parent 983a7d0 commit 030f214
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ public KsqlAggregateFunction createAggregateFunction(
case DATE:
case TIME:
case TIMESTAMP:
case STRING:
case BYTES:
return new MaxKudaf(FUNCTION_NAME, initArgs.udafIndex(), argSchema);
default:
throw new KsqlException(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ public KsqlAggregateFunction createAggregateFunction(
case DATE:
case TIME:
case TIMESTAMP:
case STRING:
case BYTES:
return new MinKudaf(FUNCTION_NAME, initArgs.udafIndex(), argSchema);
default:
throw new KsqlException(
Expand Down

0 comments on commit 030f214

Please sign in to comment.