Try again

confluentinc · Apr 3, 2020 · 4e255f0 · 4e255f0
1 parent 7a92436
commit 4e255f0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/ksqldb-cli/src/main/java/io/confluent/ksql/cli/console/UnclosedQuoteChecker.java b/ksqldb-cli/src/main/java/io/confluent/ksql/cli/console/UnclosedQuoteChecker.java
@@ -32,8 +32,7 @@ public static boolean isUnclosedQuote(final String line) {
     for (int i = 0; line != null && i < line.length(); ++i) {
       if (quoteStart < 0 && isQuoteChar(line, i)) {
         quoteStart = i;
-      } else if (quoteStart >= 0 && line.charAt(quoteStart) == line.charAt(i)
-          && !isEscaped(line, i)) {
+      } else if (quoteStart >= 0 && isQuoteChar(line, i) && !isEscaped(line, i)) {
         quoteStart = -1;
       }
     }

diff --git a/ksqldb-cli/src/test/java/io/confluent/ksql/cli/console/UnclosedQuoteCheckerTest.java b/ksqldb-cli/src/test/java/io/confluent/ksql/cli/console/UnclosedQuoteCheckerTest.java
@@ -23,7 +23,7 @@ public class UnclosedQuoteCheckerTest {
   @Test
   public void shouldFindUnclosedQuote() {
     // Given:
-    final String line = "some line 'this is in a comment";
+    final String line = "some line 'this is in a quote";
 
     // Then:
     Assert.assertTrue(UnclosedQuoteChecker.isUnclosedQuote(line));
@@ -32,7 +32,7 @@ public void shouldFindUnclosedQuote() {
   @Test
   public void shouldFindUnclosedQuote_escaped() {
     // Given:
-    final String line = "some line 'this is in a comment\\'";
+    final String line = "some line 'this is in a quote\\'";
 
     // Then:
     Assert.assertTrue(UnclosedQuoteChecker.isUnclosedQuote(line));
@@ -59,7 +59,7 @@ public void shouldNotFindUnclosedQuote_endsNonQuote() {
   @Test
   public void shouldNotFindUnclosedQuote_inComment() {
     // Given:
-    final String line = "some line -- 'this is in a quote";
+    final String line = "some line -- 'this is in a comment";
 
     // Then:
     Assert.assertFalse(UnclosedQuoteChecker.isUnclosedQuote(line));