Catches listener errors

confluentinc · Feb 10, 2020 · 9c126ea · 9c126ea
1 parent ba8c6c9
commit 9c126ea
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/HeartbeatAgent.java b/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/HeartbeatAgent.java
@@ -223,9 +223,7 @@ private void processHeartbeats(final long windowStart, final long windowEnd) {
           }
           return status;
         });
-        for (HostStatusListener listener : hostStatusListeners) {
-          listener.onHostStatusUpdated(getHostsStatus());
-        }
+        notifyListeners();
         return;
       }
 
@@ -256,8 +254,16 @@ private void processHeartbeats(final long windowStart, final long windowEnd) {
               .withHostAlive(isAlive).withLastStatusUpdateMs(windowEnd));
         }
       }
+      notifyListeners();
+    }
+
+    private void notifyListeners() {
       for (HostStatusListener listener : hostStatusListeners) {
-        listener.onHostStatusUpdated(getHostsStatus());
+        try {
+          listener.onHostStatusUpdated(getHostsStatus());
+        } catch (Throwable t) {
+          LOG.error("Error while notifying listener", t);
+        }
       }
     }