refactor: remove ExecutionContext.execute(stmt) completely (#3561)

* refactor: execute(stmt) for execute(ctx, stmt) on StatementExecutor * refactor: execute(stmt) for execute(ctx, stmt) on StandaloneExecutor * refactor: execute(stmt) for execute(ctx, stmt) on KsqlEngineTestUtil * refactor: remove execute(stmt) from KsqlExecutionContext interface
confluentinc · Oct 14, 2019 · c0bfa41 · c0bfa41
1 parent 56b46de
commit c0bfa41
Show file tree

Hide file tree

Showing 15 changed files with 367 additions and 143 deletions.
diff --git a/ksql-engine/src/main/java/io/confluent/ksql/KsqlExecutionContext.java b/ksql-engine/src/main/java/io/confluent/ksql/KsqlExecutionContext.java
@@ -88,13 +88,6 @@ public interface KsqlExecutionContext {
    */
   PreparedStatement<?> prepare(ParsedStatement stmt);
 
-  /**
-   * Executes a statement using the engine's primary service context.
-   *
-   * @see #execute(ServiceContext, ConfiguredStatement)
-   */
-  ExecuteResult execute(ConfiguredStatement<?> statement);
-
   /**
    * Execute the supplied statement, updating the meta store and registering any query.
    *

diff --git a/ksql-engine/src/main/java/io/confluent/ksql/engine/KsqlEngine.java b/ksql-engine/src/main/java/io/confluent/ksql/engine/KsqlEngine.java
@@ -159,13 +159,6 @@ public PreparedStatement<?> prepare(final ParsedStatement stmt) {
     return primaryContext.prepare(stmt);
   }
 
-  @Override
-  public ExecuteResult execute(
-      final ConfiguredStatement<?> statement
-  ) {
-    return execute(primaryContext.getServiceContext(), statement);
-  }
-
   @Override
   public ExecuteResult execute(
       final ServiceContext serviceContext,

diff --git a/ksql-engine/src/main/java/io/confluent/ksql/engine/SandboxedExecutionContext.java b/ksql-engine/src/main/java/io/confluent/ksql/engine/SandboxedExecutionContext.java
@@ -79,13 +79,6 @@ public PreparedStatement<?> prepare(final ParsedStatement stmt) {
     return engineContext.prepare(stmt);
   }
 
-  @Override
-  public ExecuteResult execute(
-      final ConfiguredStatement<?> statement
-  ) {
-    return execute(engineContext.getServiceContext(), statement);
-  }
-
   @Override
   public ExecuteResult execute(
       final ServiceContext serviceContext,