Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI should not start up if server is down #360

Closed
mjsax opened this issue Oct 11, 2017 · 2 comments
Closed

CLI should not start up if server is down #360

mjsax opened this issue Oct 11, 2017 · 2 comments
Labels

Comments

@mjsax
Copy link
Member

mjsax commented Oct 11, 2017

I was playing with the Docker Demo. I forgot the start the KSQL Server and did log into CLI directly. After doing the first command, I got

java.net.ConnectException: Connection refused

This error is not optimal -- even if I immediately realized that the server was not running. (1) the error message can be improved (2) maybe the CLI should not even start up if the server is down in the first place.

The same happens, if Confluent Platform is not started up yet. (3) There should be different error messages for different services that are not available.

@mjsax mjsax added the bug label Oct 11, 2017
@miguno
Copy link
Contributor

miguno commented Oct 16, 2017

FYI: Also tracked internally under ticket 358.

rodesai added a commit that referenced this issue Dec 13, 2017
The goal here is to provide more useful error messaging
in the cli. This includes more informative messages for certain
errors, and leveraging exception causes to provide more info:

* Add a CommonUtils class for common utility methods. Currently,
  this includes methods for printing error messages that can
  include information about the errors/exceptions that caused
  the exception for which a message is being generated.

* Print a more visible warning if the ksql server cannot be
  contacted when the cli is started in remote mode.

* Wrap rest client errors in a new exception class
  KsqlRestClientException, and provide a more context-specific error
  message.

Fixes #360
@apurvam
Copy link
Contributor

apurvam commented Dec 13, 2017

Fixed by #514

@apurvam apurvam closed this as completed Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants