Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple CLI from ROWKEY #4928

Closed
big-andy-coates opened this issue Mar 30, 2020 · 0 comments · Fixed by #4929
Closed

decouple CLI from ROWKEY #4928

big-andy-coates opened this issue Mar 30, 2020 · 0 comments · Fixed by #4929
Assignees

Comments

@big-andy-coates
Copy link
Contributor

The CLI relies on the key being named ROWKEY. After #3536 this will no longer be the case.

big-andy-coates added a commit to big-andy-coates/ksql that referenced this issue Mar 30, 2020
fixes: confluentinc#4928

The server response when describing a source schema now includes `fieldType='SYSTEM'` or `fieldType='KEY'` to differentiate system columns, i.e. ROWTIME, and key columns from value column.

The default is no field type. This design decision was taken as the `FieldInfo` pojo is used not just to describe the columns in the schema, but also fields in structs and a fieldType of `VALUE` wouldn't make much sense for a struct field. Where as no field type kind of works.
@big-andy-coates big-andy-coates self-assigned this Mar 30, 2020
big-andy-coates added a commit that referenced this issue Mar 31, 2020
* chore: decouple CLI from ROWKEY

fixes: #4928

The server response when describing a source schema now includes `fieldType='SYSTEM'` or `fieldType='KEY'` to differentiate system columns, i.e. ROWTIME, and key columns from value column.

The default is no field type. This design decision was taken as the `FieldInfo` pojo is used not just to describe the columns in the schema, but also fields in structs and a fieldType of `VALUE` wouldn't make much sense for a struct field. Where as no field type kind of works.

Co-authored-by: Andy Coates <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant