Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeGen error on GROUP BY or PARTITION BY boolean expression #4939

Closed
big-andy-coates opened this issue Mar 30, 2020 · 0 comments · Fixed by #4940
Closed

CodeGen error on GROUP BY or PARTITION BY boolean expression #4939

big-andy-coates opened this issue Mar 30, 2020 · 0 comments · Fixed by #4940
Assignees
Labels

Comments

@big-andy-coates
Copy link
Contributor

big-andy-coates commented Mar 30, 2020

The ksqlDB syntax allows boolean expressions in GROUP BY and PARTITION BY clauses:

SELECT * FROM FOO PARTITION BY A AND B;
SELECT * FROM FOO PARTITION BY NOT B;
SELECT COUNT(1) FROM FOO GROUP BY A OR C;

However, though these parse they result in exceptions during code generation.

@big-andy-coates big-andy-coates self-assigned this Mar 30, 2020
big-andy-coates added a commit to big-andy-coates/ksql that referenced this issue Mar 30, 2020
fixes: confluentinc#4939

Change to SQL syntax to not allow GROUP BY and PARTITION BY on boolean expressions. Only value expressions will be allowed.
big-andy-coates added a commit that referenced this issue Mar 30, 2020
…4940)

fixes: #4939

Change to SQL syntax to not allow GROUP BY and PARTITION BY on boolean expressions. Only value expressions will be allowed.

Co-authored-by: Andy Coates <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant