Verify that table joins use the key in the join criterion #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this target |
hjafarpour
approved these changes
Aug 9, 2018
| @@ -481,6 +483,44 @@ public void shouldNotPerformJoinIfInputPartitionsMisMatch() { | |||
| assertEquals(JoinNode.JoinType.OUTER, joinNode.getJoinType()); | |||
| } | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
| @Test | |||
| public void shouldFailJoinIfTableCriteriaColumnIsNotKey() { | |||
There was a problem hiding this comment.
Did you mean join criteria column?
There was a problem hiding this comment.
No I mean the table's column in the join criteria.
| String.format( | ||
| "Source table key column (%s) is not the column used in the join criteria (%s).", | ||
| schemaKStream.getKeyField().name(), | ||
| keyFieldName |
There was a problem hiding this comment.
Can we also include the table alias in the message. It would make it less ambiguous if we have columns with the same name in both sides of the join.
apurvam
approved these changes
Aug 9, 2018
| left, | ||
| right, | ||
| leftKeyFieldName, | ||
| "COL0", |
There was a problem hiding this comment.
Probably add a comment in this test and the other that this should be COL1.
|
Currently this targets the branch for #1697, since it depends on the function added there for field name comparison. Once that PR gets merged I'll update this to target 5.0.x |
rodesai
force-pushed
the
fix_key_selection_5.0.x
branch
2 times, most recently
from
f5ec518
to
15ab445
Compare
rodesai
force-pushed
the
check_table_keys_on_join
branch
from
553363a
to
786d3e8
Compare
rodesai
force-pushed
the
check_table_keys_on_join
branch
from
e1b81bf
to
5024527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verify that table joins use the key in the join criterion
Fixes #1712
Testing done
Added unit tests to JoinNodeTest
Reviewer checklist