MINOR: Fix bug encountered when restoring RUN SCRIPT command. #2263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if you execute a RUN SCRIPT where the script contains a persistent query, then try to restart the KSQL server, the server will fail to restart. This happens because recent changes we introduced to the recovery logic result in the server attempting to start the persistent query created by the RUN SCRIPT twice, resulting in the following error:
The fix is simple: only start RUN SCRIPT queries once when recovering.
Testing done
Manual testing done. Added unit test.
Reviewer checklist