Minor: Mark the keyField
of structured and plan nodes optional.
#2604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
keyField
of the nodes and streams involved in building a query can be null. (Yes, even on tables!). Switch the implementation to make this explicit, but usingOptional
.(This is another quick refactor to improve things before we add in Structured Keys)
Testing done
None functional change,.
Reviewer checklist