Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch KSQL over from using the Connect Schema type to represent schemas to KsqlSchema #2763

Merged
merged 2 commits into from
May 1, 2019

Conversation

big-andy-coates
Copy link
Contributor

@big-andy-coates big-andy-coates commented May 1, 2019

Description

A preparatory PR for the structured keys work (#824) that switch KSQL over from internally passing around and storing schemas using the Connect Schema type to a KSQL specific KsqlSchema.

Some places, e.g. serde classes, still use the Schema type as they are dealing specifically with the value only so don't need the key.

Internally, KsqlSchema still uses the Connect Schema type. Later it will be enhanced to have the key schema as well.

The PR tries to minimise code change as this is already a wide reaching PR. The main changes are:

  1. Switch KSQL from using Schema to KsqlSchema in most places in the code.
  2. Moved code from SchemaUtil into KsqlSchema where it made sense. Note: this PR does not attempt to fix bugs or refactor the implementation of this methods. That will come later.
  3. A sneaky rename of two params to JoinNode that got missed on a previous PR.

Testing done

Lots more tests added around the SchemaUtil code that now lives in KsqlSchema.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates requested a review from a team as a code owner May 1, 2019 22:06
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick scan and it lgtm - one comment about json backwards compatibility but the approach is sound to me (barring green build of course).

@agavra agavra requested a review from a team May 1, 2019 22:16
@big-andy-coates big-andy-coates merged commit 6d76fe1 into confluentinc:master May 1, 2019
@big-andy-coates big-andy-coates deleted the ksql_schema branch May 1, 2019 23:33
@big-andy-coates big-andy-coates mentioned this pull request May 2, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants