Switch KSQL over from using the Connect Schema
type to represent schemas to KsqlSchema
#2763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A preparatory PR for the structured keys work (#824) that switch KSQL over from internally passing around and storing schemas using the Connect
Schema
type to a KSQL specificKsqlSchema
.Some places, e.g. serde classes, still use the
Schema
type as they are dealing specifically with the value only so don't need the key.Internally,
KsqlSchema
still uses the ConnectSchema
type. Later it will be enhanced to have the key schema as well.The PR tries to minimise code change as this is already a wide reaching PR. The main changes are:
Schema
toKsqlSchema
in most places in the code.SchemaUtil
intoKsqlSchema
where it made sense. Note: this PR does not attempt to fix bugs or refactor the implementation of this methods. That will come later.JoinNode
that got missed on a previous PR.Testing done
Lots more tests added around the
SchemaUtil
code that now lives inKsqlSchema
.Reviewer checklist