Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add extension for custom metrics (5.3.x) #2997

Merged
merged 4 commits into from
Jul 20, 2019
Merged

feat: add extension for custom metrics (5.3.x) #2997

merged 4 commits into from
Jul 20, 2019

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Jun 20, 2019

Description

Backport changes from #2984 to 5.3.x.

Note that this PR includes changes from #2996 as the first commit in the PR. Only the second commit should be reviewed.

Testing done

Manual + unit tests.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested review from JimGalasyn and a team as code owners June 20, 2019 17:16
@vcrfxia vcrfxia changed the title Add extension for custom metrics (5.3.x) feat: add extension for custom metrics (5.3.x) Jul 19, 2019
@vcrfxia vcrfxia merged commit 94a8ae7 into confluentinc:5.3.x Jul 20, 2019
@vcrfxia vcrfxia deleted the custom-metrics-5.3 branch July 20, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

@JimGalasyn JimGalasyn Awaiting requested review from JimGalasyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vcrfxia @agavra