Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove delete.topic.enable check #3089

Merged
merged 5 commits into from
Jul 18, 2019
Merged

fix: Remove delete.topic.enable check #3089

merged 5 commits into from
Jul 18, 2019

Commits on Jul 17, 2019

  1. fix: remove delete.topic.enable check

    @spena
    spena committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    b6b4ea3 View commit details
    Browse the repository at this point in the history

  2. fix: detect TopicDeletionDisabledException 

    TopicDeletionDisabledException is used to detect if Kafka has
the delete.topic.enable config set to True. If true, then deletion
is ignored by Cluster Terminate, but an error is displayed when using
DROP STREAM DELETE TOPIC
    @spena
    spena committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    533dac3 View commit details
    Browse the repository at this point in the history

  3. fix: remove execution retries from DROP STREAM DELETE TOPIC 

    Retrying a DROP STREAM DELETE TOPIC commands are delayed when
retrying the failed command. This is not necessary when the
TopicDeletionDisabledException is False, and even for any
other error. Users can retry the command manually if it fails.
    @spena
    spena committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    22bffea View commit details
    Browse the repository at this point in the history

  4. test: add test cases

    @spena
    spena committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    3ee5ee8 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. fix: avoid log and throw anti-pattern

    @spena
    spena committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    3fb30cb View commit details
    Browse the repository at this point in the history