-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-some-unit-tests #312
add-some-unit-tests #312
Conversation
Can one of the admins verify this patch? |
It looks like @TheRealHaui hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
[clabot:check] |
@confluentinc It looks like @TheRealHaui just signed our Contributor License Agreement. 👍 Always at your service, clabot |
@TheRealHaui Thanks for your contribution. You need to sign Contributor License Agreement before merging your PRs. |
[clabot:check] |
@confluentinc It looks like @TheRealHaui just signed our Contributor License Agreement. 👍 Always at your service, clabot |
@hjafarpour |
@TheRealHaui We made some refactoring in the code. Would you please update your code accordingly before we can merge it. |
@hjafarpour : If @TheRealHaui doesn't have the time to follow-up, I'd suggest that we help to update the code in this PR to match latest |
I am going to update the code in the next few days. |
Thanks for the kind proposal. |
Great, that's even better. :-) Thank you! |
…build-issues Ksql 388 fix 400 build issues
…-388-fix-400-build-issues Revert "Ksql 388 fix 400 build issues"
Updated to meet refactoring demands.
@hjafarpour, @miguno |
Updated branch to current code. |
@TheRealHaui - you can ignore codacy... |
@TheRealHaui - sorry - but we are working on the 4.0.x branch. Its to do with some upcoming work. Would you be able to switch it over? |
Something went completely wrong during switching to 4.0.x branch ... |
@hjafarpour |
retest this please |
@dguy Unfortunately I can't build anything using the 4.0.x branch! |
Any advice? |
@TheRealHaui you could try adding:
|
@dguy Thanks for merging. |
Added some unit tests.