Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose user/password command line options #3129

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

spena
Copy link
Member

@spena spena commented Jul 25, 2019

Description

Exposes the --user/--password command-line options when executing ksql --help. I don't know why they were hidden if there is nothing to secure by hiding them.

Testing done

Verify ksql --help exposes the parameters:

> ksql --help
...
--password <password>, -p <password>
            If your KSQL server is configured for authentication, then provide
            your password here. The username must be specified separately with
            the -u/--user flag
...
--user <userName>, -u <userName>
            If your KSQL server is configured for authentication, then provide
            your user name here. The password must be specified separately with
            the -p/--password flag
...

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@spena spena added this to the 5.4 milestone Jul 25, 2019
@spena spena requested a review from a team July 25, 2019 16:00
@spena spena self-assigned this Jul 25, 2019
Copy link
Contributor

@rodesai rodesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spena spena merged commit 1fd70fa into confluentinc:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants