feat(ksql-connect): introduce ConnectClient for REST requests #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodesai
reviewed
Jul 29, 2019
|
|
||
| return connectResponse; | ||
| } catch (final Exception e) { | ||
| throw new KsqlException(e); |
There was a problem hiding this comment.
maybe define a new exception type for connect client errors that inherits from RuntimeException.
There was a problem hiding this comment.
I will reuse KsqlServerException here - if later we need a strong type for connect errors we can do that minor refactor. Don't want to unnecessarily add boilerplate.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a client that can issue requests to connect and wires it through the
ServiceContextas well as make the necessarypom.xmlchanges. This is part 1 of a few PRs for connect integration and an effort to keep them small.Testing done
Unit testing for the new components, but there isn't actually any new functionality that is introduced with this change.
Reviewer checklist