feat(ksql-connect): introduce syntax for CREATE CONNECTOR (syntax only) #3139
Conversation
| @@ -291,6 +292,7 @@ qualifiedName | |||
| identifier | |||
| : IDENTIFIER #unquotedIdentifier | |||
| | QUOTED_IDENTIFIER #quotedIdentifierAlternative | |||
| | STRING #stringIdentifier | |||
There was a problem hiding this comment.
ANSI standard is to have " for identifiers and ' for constants - most DBs don't really follow this (Postgres does, but MySQL and SQL-Server don't). Since we use identifier in tableProperties it's either we allow ' or we deal with needing to do "foo"='bar' which I think is incredibly confusing, or we duplicate a bunch of code to allow ' in table properties, but not in other identifiers...
There was a problem hiding this comment.
Why do we need to add STRING here?
There was a problem hiding this comment.
All of the other syntax only allow for " for identifiers, not ' - I just reused STRING because it allows for '.
There was a problem hiding this comment.
Talked offline here. The problem is that identifiers and literals need to be differentiated in the select statements (e.g. SELECT 'foo' and SELECT "foo" are different, one refers to literals the other refers to a column)
Description
As part 2 of a series of PRs related to connect integration, this one adds syntax for
CREATE (SOURCE | SINK) CONNECTOR. This does not wire in anything, these statements will parse but nothing more.Testing done
Unit testing
Reviewer checklist