Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove non-standard JavaFx usage of Pair #3145

Merged
merged 1 commit into from
Jul 30, 2019
Merged

fix: remove non-standard JavaFx usage of Pair #3145

merged 1 commit into from
Jul 30, 2019

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Jul 30, 2019

javafx is not in OpenJDK, replacing usage of JavaFx with our internal Pair class.

@agavra agavra requested a review from a team as a code owner July 30, 2019 02:50
apurvam
apurvam approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the prompt turnaround @agavra !

@agavra agavra merged commit 3508847 into confluentinc:master Jul 30, 2019
@agavra agavra deleted the remove_pair branch December 2, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurvam apurvam apurvam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agavra @apurvam