Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change rowtime rewrite conditions and add error handling #3209

Merged
merged 5 commits into from
Aug 16, 2019

Conversation

jzaralim
Copy link
Contributor

Description

There were some concerns about #3160 after it had been merged. This PR makes the following changes:

  1. Instead of wrapping datestrings in STRINGTOTIMESTAMP, convert them into longs. This allows for error handling to be handled in the rewrite instead of with STRINGTOTIMESTAMP
  2. Added some more test cases to cover some edge cases
  3. Change the conditions for rewriting to be just if one side is ROWTIME and the other a string.

Testing done

Passes unit and QTT tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested review from big-andy-coates and a team August 14, 2019 00:18
Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jzaralim jzaralim merged commit f41c246 into confluentinc:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants