fix: find bugs issue in KafkaTopicClientImpl

[big-andy-coates]

Description

Find bugs issue to do with incorrect number of arguments to String.format.

Of course, we all know you shouldn't use String.format in log lines anyway ;)

Testing done

mvn test

Reviewer checklist

• Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
• Ensure relevant issues are linked (description should include text like "Fixes #")

[spena]

Looks good,

Question: why should not we use string.format in log lines? I think I got used to using it at some point when I found LOG wasn't allowing me to put more than 4 parameters.

[big-andy-coates]

Question: why should not we use string.format in log lines? I think I got used to using it at some point when I found LOG wasn't allowing me to put more than 4 parameters.

the log calls take varargs, so you can pass as many arguments as you want.

The benefit of these calls over String format is that the later does the string manipulation even if the logger is disabled, where as the former is virtually a no-op if the logger is disabled.