Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: schema converters should handle List and Map impl (MINOR) #3290

Merged
merged 1 commit into from
Sep 3, 2019
Merged

fix: schema converters should handle List and Map impl (MINOR) #3290

merged 1 commit into from
Sep 3, 2019

Conversation

big-andy-coates
Copy link
Contributor

@big-andy-coates big-andy-coates commented Sep 2, 2019 •
edited
Loading

Description

The Java to Sql schema converter should handle converting HashMap -> MAP and ArrayList -> ARRAY etc, not just the interface types themselves.

Testing done

mvn test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates
fix: schema converters should handle List and Map impl
90e0596 
The Java to Sql schema converter should handle converting `HashMap` -> `MAP` and `ArrayList` -> `ARRAY` etc, not just the interface types themselves.
@big-andy-coates big-andy-coates requested a review from a team as a code owner September 2, 2019 16:25
@vpapavas
Copy link
Member

vpapavas commented Sep 3, 2019

LGTM +1

@big-andy-coates big-andy-coates merged commit af779dc into confluentinc:master Sep 3, 2019
@big-andy-coates big-andy-coates deleted the impl_conv branch September 3, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-andy-coates @vpapavas