Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for datagen to produce indefinitely (MINOR) #3307

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Sep 6, 2019

Description

BREAKING CHANGE: If no value is passed for the KSQL datagen option iterations, datagen will now produce indefinitely, rather than terminating after a default of 1,000,000 rows.

This change is valuable because previously there was no way to specify that datagen should produce indefinitely. This PR adds this ability, and updates it to be the default behavior. (Users can still use the old behavior of terminating the process after a fixed number of rows by passing that number via iterations.)

Testing done

Manual.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from a team as a code owner September 6, 2019 15:54
Copy link
Contributor

@big-andy-coates big-andy-coates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vcrfxia

Might it not be better to just allow the app to be run without the iterations flag if you want it to run for ever?

@vcrfxia
Copy link
Contributor Author

vcrfxia commented Sep 6, 2019

@big-andy-coates good point. The current behavior is to default to producing 1,000,000 rows if the iterations property is not explicitly set. Unless we're concerned with maintaining backwards compatibility of this default, I will update the PR to change the default behavior to be indefinite production, removing the need for the special -1 value in the process.

@vcrfxia vcrfxia merged commit 6281738 into confluentinc:master Sep 6, 2019
@vcrfxia vcrfxia deleted the infinite-datagen branch September 6, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants