Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert default listeners value and update docs #3314

Merged
merged 1 commit into from
Sep 10, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions config/ksql-server.properties
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@

### HTTP ###
# The URL the KSQL server will listen on:
# The default is any IPv4 or IPv6 interface on the machine.
listeners=http://0.0.0.0:8088,http://[::]:8088
# The default is any IPv4 interface on the machine.
listeners=http://0.0.0.0:8088

# Use the 'listeners' line below for any IPv6 interface on the machine.
# listeners=http://[::]:8088

### HTTPS ###
# To switch KSQL over to communicating using HTTPS comment out the 'listeners' line above
Expand Down
2 changes: 1 addition & 1 deletion docs/installation/installing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Follow these instructions to start KSQL server using the ``ksql-server-start`` s
::

bootstrap.servers=localhost:9092
listeners=http://0.0.0.0:8088,http://[::]:8088
listeners=http://0.0.0.0:8088

For more information, see :ref:`ksql-server-config`.

Expand Down
10 changes: 7 additions & 3 deletions docs/installation/server-config/config-reference.rst
Original file line number Diff line number Diff line change
Expand Up @@ -356,13 +356,17 @@ listeners
The ``listeners`` setting controls the REST API endpoint for the KSQL server.
For more info, see :ref:`ksql-rest-api`.

The default ``listeners`` is ``http://0.0.0.0:8088,http://[::]:8088``, which binds to all IPv4 and IPv6 interfaces.
The default ``listeners`` is ``http://0.0.0.0:8088``, which binds to all IPv4 interfaces.
Set ``listeners`` to ``http://[::]:8088`` to bind to all IPv6 interfaces.
Update this to a specific interface to bind only to a single interface. For example:

::

# Bind to all interfaces, (both IPv4 and IPv6).
listeners=http://0.0.0.0:8088,http://[::]:8088
# Bind to all IPv4 interfaces.
listeners=http://0.0.0.0:8088

# Bind to all IPv6 interfaces.
listeners=http://[::]:8088

# Bind only to localhost.
listeners=http://localhost:8088
Expand Down
2 changes: 1 addition & 1 deletion docs/tutorials/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ services:
- schema-registry
environment:
KSQL_BOOTSTRAP_SERVERS: kafka:39092
KSQL_LISTENERS: http://0.0.0.0:8088,http://[::]:8088
KSQL_LISTENERS: http://0.0.0.0:8088
KSQL_KSQL_SCHEMA_REGISTRY_URL: http://schema-registry:8081