Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(static): add forEach() to KsqlStruct (MINOR) #3320

Merged
merged 1 commit into from
Sep 11, 2019
Merged

feat(static): add forEach() to KsqlStruct (MINOR) #3320

merged 1 commit into from
Sep 11, 2019

Conversation

big-andy-coates
Copy link
Contributor

Description

Iterating across the values and their schemas is a common pattern, so lets add a method to facilitate.

Testing done

Usual

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates
feat(static): add forEach() to KsqlStruct (MINOR)
60697e8 
Iterating across the values and their schemas is a common pattern, so lets add a method to facilitate.
@big-andy-coates big-andy-coates requested a review from a team as a code owner September 10, 2019 16:33
purplefox
purplefox approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@purplefox purplefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@big-andy-coates big-andy-coates merged commit 587b545 into confluentinc:master Sep 11, 2019
@big-andy-coates big-andy-coates deleted the struct_foreach branch September 11, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplefox purplefox purplefox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-andy-coates @purplefox