feat(static): static select support #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static queries now support arbitrary select expressions.
big-andy-coates
commented
Sep 17, 2019
|
|
||
| @SuppressWarnings("OptionalGetWithoutIsPresent") | ||
| @RunWith(MockitoJUnitRunner.class) |
There was a problem hiding this comment.
This test was actually just renamed to QueryAnalyzerFunctionalTest. This is just a bad diff by Git.
QueryAnalyzerFunctionalTest continuous to be a functional style that parses actual sql and then analyses it.
QueryAnalyzerTest is now a unit test.
big-andy-coates
commented
Sep 17, 2019
| * <p>This test file is more of a functional test, which is better implemented using QTT. | ||
| */ | ||
| @SuppressWarnings("OptionalGetWithoutIsPresent") | ||
| public class QueryAnalyzerFunctionalTest { |
There was a problem hiding this comment.
renamed from QueryAnalyzerTest. Please do not review this file - I haven't changed it!
purplefox
requested review from
purplefox
and removed request for
purplefox
purplefox
reviewed
Sep 18, 2019
purplefox
reviewed
Sep 18, 2019
purplefox
reviewed
Sep 18, 2019
ksql-engine/src/main/java/io/confluent/ksql/analyzer/QueryValidator.java
Outdated
Show resolved
Hide resolved
purplefox
reviewed
Sep 18, 2019
ksql-engine/src/main/java/io/confluent/ksql/analyzer/StaticQueryValidator.java
Outdated
Show resolved
Hide resolved
purplefox
reviewed
Sep 18, 2019
ksql-engine/src/test/java/io/confluent/ksql/analyzer/ContinuousQueryValidatorTest.java
Outdated
Show resolved
Hide resolved
purplefox
reviewed
Sep 18, 2019
ksql-engine/src/test/java/io/confluent/ksql/analyzer/ExpressionAnalyzerTest.java
Show resolved
Hide resolved
purplefox
reviewed
Sep 18, 2019
ksql-engine/src/test/java/io/confluent/ksql/analyzer/ExpressionAnalyzerTest.java
Show resolved
Hide resolved
purplefox
reviewed
Sep 18, 2019
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/StaticQueryExecutor.java
Show resolved
Hide resolved
purplefox
reviewed
Sep 18, 2019
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/StaticQueryExecutor.java
Show resolved
Hide resolved
vpapavas
reviewed
Sep 19, 2019
ksql-engine/src/main/java/io/confluent/ksql/analyzer/ExpressionAnalyzer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
static queries now support arbitrary select expressions, e.g.
As part of this PR I've looked to start to make use of the
QueryAnalyzerto analyze static queries. I've also pulled the validation of static and continuous queries into their own validator classes, to make them more targeted:StaticQueryValidatorandContinuousQueryValiator, respectively.As before, don't worry overly about the code in
StaticQueryExecutor- it's temporary.Testing done
Suitable tests added, then
mvn testReviewer checklist