Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address upstream change in KafkaAvroDeserializer #3372

Merged
merged 1 commit into from
Sep 18, 2019
Merged

fix: address upstream change in KafkaAvroDeserializer #3372

merged 1 commit into from
Sep 18, 2019

Conversation

stevenpyzhang
Copy link
Member

@stevenpyzhang stevenpyzhang commented Sep 17, 2019 •
edited
Loading

Description

Build broken after change due to unchecked warning: confluentinc/schema-registry@c4b4879

Testing done

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@stevenpyzhang stevenpyzhang requested a review from a team as a code owner September 17, 2019 22:44
@stevenpyzhang stevenpyzhang force-pushed the fix-avro-and-sr branch 3 times, most recently from 4308fba to 734eae8 Compare September 18, 2019 00:18
@stevenpyzhang stevenpyzhang changed the title fix: address upstream change in KafkaAvroDeserializer fix: address upstream change in SR KafkaAvroDeserializer and RestService Sep 18, 2019
@stevenpyzhang stevenpyzhang changed the title fix: address upstream change in SR KafkaAvroDeserializer and RestService fix: address upstream change in KafkaAvroDeserializer Sep 18, 2019
big-andy-coates
big-andy-coates approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@big-andy-coates big-andy-coates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenpyzhang, LGTM

@big-andy-coates
Copy link
Contributor

Merging, as this helps with part of the master build issues...

@big-andy-coates big-andy-coates merged commit b32e6a9 into confluentinc:master Sep 18, 2019
@stevenpyzhang stevenpyzhang mentioned this pull request Sep 27, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

@big-andy-coates big-andy-coates big-andy-coates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenpyzhang @big-andy-coates @agavra