feat(static): allow logical schema to have fields in any order #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our logical schema should be able to support schemas where the is not key column, no rowtime, or has key columns interleaved with value columns. This is because a projection does not necessarily include key at the start, or at all, or rowtime.
agavra
approved these changes
Sep 26, 2019
ksql-common/src/main/java/io/confluent/ksql/schema/ksql/LogicalSchema.java
Outdated
Show resolved
Hide resolved
ksql-common/src/main/java/io/confluent/ksql/schema/ksql/LogicalSchema.java
Show resolved
Hide resolved
ksql-common/src/main/java/io/confluent/ksql/schema/ksql/LogicalSchema.java
Show resolved
Hide resolved
# Conflicts: # ksql-common/src/main/java/io/confluent/ksql/schema/ksql/LogicalSchema.java # ksql-common/src/test/java/io/confluent/ksql/schema/ksql/LogicalSchemaTest.java # ksql-execution/src/test/java/io/confluent/ksql/execution/util/ExpressionTypeManagerTest.java
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our logical schema should be able to support schemas where the is not key column, no rowtime, or has key columns interleaved with value columns. This is because a projection does not necessarily include key at the start, or at all, or rowtime.
This is necessary for the static query work (or is that a pull query? or a push?) as the query may not include ROWKEY or ROWTIME.
This will also be needed soon for the primitive key work as well.
This PR see's a big change to the
LogicalSchemaclass - it now just has a single collection ofNamespacedColumn. The namespace bit distinguishes between metadata, key and value columns.How to review:
LogicalSchema.Testing done
Usual
Reviewer checklist