Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in static query WHERE clause example #3423

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Sep 26, 2019

Description

Issuing a static query with WINDOWSTART bounds of the form WHERE a < WINDOWSTART AND WINDOWSTART < b returns in the error:

Server failed to execute statement
statement: 
reason: Unsupported WINDOWSTART bounds: [GREATER_THAN]
Static queries currently require a WHERE clause that:
 - limits the query to a single ROWKEY, e.g. `SELECT * FROM X WHERE ROWKEY=Y;`.
 - limits the time bounds of the windowed table. This can be: 
    + a single window lower bound, e.g. `WHERE WINDOWSTART = z`, or
    + a range, e.g. `WHERE a < WINDOWSTART AND WINDOWSTART < b
WINDOWSTART currently supports operators: [EQUAL, GREATER_THAN_OR_EQUAL, LESS_THAN]
WINDOWSTART currently comparison with epoch milliseconds or a datetime string in the form: yyyy-MM-dd'T'HH:mm:ss.SSS

This PR updates the error message to show what the form of the bounds actually needs to be.

Testing done

Non-functional change.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from a team as a code owner September 26, 2019 17:15
Copy link
Contributor

@big-andy-coates big-andy-coates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thanks Vic!

@vcrfxia vcrfxia merged commit 7ad3248 into confluentinc:master Sep 27, 2019
@vcrfxia vcrfxia deleted the static-query-window-bounds branch September 27, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants