fix: Rename Delimiter:parse(char c) to Delimiter.of(char c) #3433

purplefox · 2019-09-27T14:47:34Z

Description

Renames Delimiter:parse(char c) to Delimiter.of(char c)

Testing done

Run test suite

Reviewer checklist

Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
Ensure relevant issues are linked (description should include text like "Fixes #")

big-andy-coates

LGTM

Tim Fox added 3 commits September 26, 2019 18:36

fix:rename Delimiter.of(String) to Delimiter.parse(String)

faeaed2

Merge branch 'master' into rename_to_parse

1ec7a82

Renamed Delimiter.parse to of for single char

ab491d5

purplefox requested a review from a team as a code owner September 27, 2019 14:47

purplefox requested a review from big-andy-coates September 27, 2019 14:48

purplefox changed the title ~~fix: Rename to parse~~ fix: Renames Delimiter:parse(char c) to Delimiter.of(char c) Sep 27, 2019

purplefox changed the title ~~fix: Renames Delimiter:parse(char c) to Delimiter.of(char c)~~ fix: Rename Delimiter:parse(char c) to Delimiter.of(char c) Sep 27, 2019

big-andy-coates approved these changes Sep 27, 2019

View reviewed changes

purplefox merged commit 8716c41 into confluentinc:master Sep 27, 2019

purplefox deleted the rename_to_parse branch September 30, 2019 06:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Rename Delimiter:parse(char c) to Delimiter.of(char c) #3433

fix: Rename Delimiter:parse(char c) to Delimiter.of(char c) #3433

purplefox commented Sep 27, 2019 •

edited

Loading

big-andy-coates left a comment

fix: Rename Delimiter:parse(char c) to Delimiter.of(char c) #3433

fix: Rename Delimiter:parse(char c) to Delimiter.of(char c) #3433

Conversation

purplefox commented Sep 27, 2019 • edited Loading

Description

Testing done

Reviewer checklist

big-andy-coates left a comment

Choose a reason for hiding this comment

purplefox commented Sep 27, 2019 •

edited

Loading