fix: changes required for compatibility with KIP-479 #3466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbejeck
commented
Oct 3, 2019
| final String name, | ||
| final String storeName) { | ||
| return StreamJoined.with(keySerde, leftSerde, rightSerde) | ||
| .withName(name).withStoreName(storeName); |
There was a problem hiding this comment.
The withStoreName is the key change/addition. If we want to stick with generated store names, we can omit the withStoreName call and update the expected topologies for the QueryTranslationTest.
agavra
approved these changes
Oct 3, 2019
rodesai
reviewed
Oct 3, 2019
bbejeck
force-pushed
the
fix_update_for_new_stream_joined_config_object
branch
2 times, most recently
from
530ae49
to
689fc83
Compare
|
rebased and updated this PR |
bbejeck
force-pushed
the
fix_update_for_new_stream_joined_config_object
branch
from
689fc83
to
1a87af9
Compare
|
rebased this |
bbejeck
commented
Oct 9, 2019
| @@ -251,6 +254,7 @@ public void shouldDoInnerJoin() { | |||
| } | |||
|
|
|||
| @Test | |||
| @SuppressFBWarnings | |||
There was a problem hiding this comment.
Spotbugs doesn't like line 266, adding this suppression for now
Return value of StreamJoinedFactory.create(Serde, Serde, Serde, String, String) ignored, but method has no side effect [io.confluent.ksql.execution.streams.StreamStreamJoinBuilderTest] At StreamStreamJoinBuilderTest.java:[line 264] RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
|
Merged #3466 into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
StreamJoinedobject from KIP-479. Specifically this PRKStream#join(KStream,....Joined)methods in favor ofKStream#join(KStream,....StreamJoined)Testing done
I updated existing tests. Since this PR does not introduce new behavior, I felt that updating the current tests is sufficient.
EDIT: I ran the
QueryTranslationTest,ksql-engine, andksql-streamstests locally and all passed.Reviewer checklist