-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SourceNode as it is redundant #368
Conversation
retest this please |
@dguy this results in errors. For instance if you run the quick start SELECT statements does not work: ksql> SELECT regionid, numusers FROM pageviews_regions LIMIT 5; Wanna take a look again and let me know when it works fine. |
@hjafarpour the above has been fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image * remove here hyperlink * Added LIKE examples to syntax guide and examples. * Fixed typo. * Minor doc changes. * Improvements to syntax guide * Restructure TOC * Fixed misspelled words * Fixed a minor error in the syntax guide. * Clarify PARTITION BY in CSAS * remove build-tools copy, use pluginRepository in pom (confluentinc#286) * Add section Use Cases and Examples * Fix typo * Add missing word to roadmap * Clarify FAQ * Remove trailing whitespace * Add Configure KSQL to Syntax Guide, fix/clariy config examples * Emit succinct error for missing query file * Add upstream project so build are triggered automatically * Clarify client-server mode * Clarifications * Add `$` to CLI commands * Clarifications * Clarifications * Clarifications * Fix typo * Remove bullet formatting * fix checkstyle errors * Document how to configure the Kafka bootstrap servers * Update non-docker-clickstream.md * Clarify KSQL works with AK and CP * small-code-quality-improvements Added code quality improvements. * small-code-quality-improvements Added code quality improvements. * added persistent information for streams and table * fixing commandstore hanging * reduced poll on priorCommands processing * removed header p html * added comment on poll instead of subscribe * Clarify how streams and tables are stored in topics * Including the streams config properties in the session with CTAS and CSAS statements in the service execution mode. * refactoring parser, core and common * extracted serde module * Refactored the package for GenericRow. * Fixed the drop table issue. * extracted pipeline Please enter the commit message for your changes. Lines starting * rename ksql-core to ksql-engine * Add to Examples: WHERE clause and content-based routing (confluentinc#333) * First step in better testing tools. Added an integration test tool to create topics and pump data into the topic and pull data from topics. * No need to set the streams application.id for the rest server. * First pass on refactoring KSQL confing. * extracting new integration test using KSQLContext Please enter the commit message for your changes. Lines starting * Refined admin client config. * remove dead code. make field and method access more restricted * bump common dependency to 3.3.1-SNAPSHOT * using 0.11.0.1 of client to use fixed AdminClient * kafka version setting to 11.0.1 * remove unused imports * remove dead code. change access modifiers. general tidy up. * Minor change to use the same Application Id for embedded mode. * Some changes based on the new KSQLConfig. * replace window-unit with TimeUnit (confluentinc#346) * skip bad data in json and delimited deserializer (confluentinc#347) * Clean up the poms after the refactor that created new packages. * More pom clean up. * Reverting adminclient singleton temporarily. * Bump to common 4.0.0-SNAPSHOT * Bump to common 4.1.0-SNAPSHOT * update slack channel for build notifications * fix artifact version in compose file * After bumping the dependency to 4.0.0 we encountered some issues that this commit fixes them. * Better clean up for queries. Internal topics will be deletted after query termination. * Added singleton AdminClient back. * extract methods, remove duplication, etc from PhysicalPlanBuilder (confluentinc#356) * Use streams 1.0 api methods (confluentinc#365) * new PR with migrated tests * tidying stuff up * trigger build * remove more crud * Fixed the pom version. * Pom version fix. * Refactored Function registry. * adding windowing integration tests, updated streams int test util to latest version * trigger * moving packages * Applied review feedback. * Remove SourceNode as it is redundant (confluentinc#368) * remove SourceNode as it is redundant * Add test for KsqlTable datasource in LogicalPlanner * adding stream-table join * exposing time controls when publishing test data * exposing time controls for int tests * removed old comments * trigger build * remove jackson dependency in ksql-rest-app. (confluentinc#369) * remove jackson dependency in ksql-rest-app. remove @JsonUnwrapped from places where it doesn't work * add missng pom update * move the createsink method out of SchemaKStream (confluentinc#376) * make join test more reliable (confluentinc#381) * rework threading on QueryStreamWriter * import * import * import * Use streams deserializtion exception handler (confluentinc#385) * extract SelectValueMapper from SchemaKXxxx (confluentinc#379) * minor tidyups * Put window aggregate logic into the various KsqlWindowExpression classes (confluentinc#377) * make the window expressions do some work * add test scope to easymock dependency * Minor modification in KSQLContext.
Removed the
SourceNode
class as it was an unnecessary level of inheritance, i.e, only extended byStructuredDataSourceNode
.Change
StructuredDataSourceNode
such that it gets most of its params from theStructuredDataSource