Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bad serde package declaration #392

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

blueedgenick
Copy link
Contributor

@blueedgenick blueedgenick commented Oct 18, 2017

i must have stricter compiler defaults in my ide or something

@hjafarpour @dguy

@ghost
Copy link

ghost commented Oct 18, 2017

It looks like @blueedgenick hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@blueedgenick
Copy link
Contributor Author

blueedgenick commented Oct 18, 2017 via email

@ghost
Copy link

ghost commented Oct 18, 2017

It looks like @blueedgenick hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@blueedgenick
Copy link
Contributor Author

blueedgenick commented Oct 18, 2017 via email

@ghost
Copy link

ghost commented Oct 18, 2017

@confluentinc It looks like @blueedgenick just signed our Contributor License Agreement. 👍

Always at your service,

clabot

Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting that intelliJ did not catch this!
LGTM.

@dguy
Copy link
Contributor

dguy commented Oct 18, 2017

retest this please

1 similar comment
@dguy
Copy link
Contributor

dguy commented Oct 19, 2017

retest this please

@dguy dguy merged commit 0ea1138 into confluentinc:4.0.x Oct 19, 2017
@blueedgenick blueedgenick deleted the fix-bad-serde-package-edits branch October 19, 2017 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants