fix: array access is now 1-indexed instead of 0-indexed #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
BREAKING CHANGE: any queries that were using array index mechanism should change to use 1-base indexing instead of 0-base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: any queries that were using array index mechanism
should change to use 1-base indexing instead of 0-base.
fixes #3949
fixes #1659
Description
Changes the array indexing to be in line with standard SQL (namely 1-indexed instead of 0-indexed). For historical context, see #1682 - since we're making this as a breaking change, we don't need to introduce it as a configurable UDF (this approach is much cleaner).
Testing done
Added unit tests and updated QTT tests.
Reviewer checklist