Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back the commented assertions in StatementExecutorTest and aCom… #406

Merged
merged 8 commits into from
Oct 28, 2017
Merged

Bring back the commented assertions in StatementExecutorTest and aCom… #406

merged 8 commits into from
Oct 28, 2017

Commits on Oct 23, 2017

  1. Bring back the commented assertions in StatementExecutorTest and aCom… 

    …mandRunnerTest
    @hjafarpour
    hjafarpour committed Oct 23, 2017
    Configuration menu
    Copy the full SHA
    9d0c608 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2017

  1. Fixed the tests.

    @hjafarpour
    hjafarpour committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    aad74d8 View commit details
    Browse the repository at this point in the history

  2. Refactored tests. Moved command computation code from the run() in th… 

    …e thread to a new method for better testablility.
    @hjafarpour
    hjafarpour committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    921ae42 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2017

  1. Merge remote-tracking branch 'upstream/4.0.x' into KSQL-402-Reinstate… 

    …-assertion-in-CommandRunnerTest-StatementExecutorTest
    @hjafarpour
    hjafarpour committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    380625d View commit details
    Browse the repository at this point in the history

  2. Made changes based on the review feedback.

    @hjafarpour
    hjafarpour committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    50f881f View commit details
    Browse the repository at this point in the history

  3. While inverstigating the tests I changed the poll time in the command… 

    … store. I am reducing it back to 5 seconds and also adding a message in KSQL console to let user know that the service is being initialized.
    @hjafarpour
    hjafarpour committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    2bdb563 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2017

  1. Extract polling time constant.

    @hjafarpour
    hjafarpour committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    ab0fd85 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/4.0.x' into KSQL-402-Reinstate… 

    …-assertion-in-CommandRunnerTest-StatementExecutorTest
    @hjafarpour
    hjafarpour committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    6750dc8 View commit details
    Browse the repository at this point in the history