chore: primitive keys for simple queries #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of a few commits to start introducing support for primitive keys in different query types. This commit opens the door for CT/CS statements with primitive keys, (`STRING`, `INT`, `BIGINT`, `BOOLEAN` and `DOUBLE`), and for using those sources in non-join, non-aggregate and non-partition-by queries.
2 tasks
stevenpyzhang
requested changes
Dec 10, 2019
| @@ -93,6 +94,10 @@ public JoinNode( | |||
| : KeyField.of(leftKeyCol.ref()); | |||
|
|
|||
| this.schema = JoinParamsFactory.createSchema(left.getSchema(), right.getSchema()); | |||
|
|
|||
| if (schema.key().get(0).type().baseType() != SqlBaseType.STRING) { | |||
| throw new KsqlException("GROUP BY is not supported with non-STRING keys"); | |||
There was a problem hiding this comment.
Should this be "JOIN is not supported"?
| @@ -45,6 +47,10 @@ public RepartitionNode( | |||
| this.source = Objects.requireNonNull(source, "source"); | |||
| this.partitionBy = Objects.requireNonNull(partitionBy, "partitionBy"); | |||
| this.keyField = Objects.requireNonNull(keyField, "keyField"); | |||
|
|
|||
| if (source.getSchema().key().get(0).type().baseType() != SqlBaseType.STRING) { | |||
| throw new KsqlException("GROUP BY is not supported with non-STRING keys"); | |||
There was a problem hiding this comment.
Should this be "PARTITION BY is not supported"?
stevenpyzhang
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
Oh I see, you fixed the error messages in the stacked #4098
LGTM then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #3534
First of a few commits to start introducing support for primitive keys in different query types.
This commit opens the door for CT/CS statements with primitive keys, (
STRING,INT,BIGINT,BOOLEANandDOUBLE), and for using those sources in non-join, non-aggregate and non-partition-by queries.Testing done
Example queries added to
key-schemas.json, which is a good place to start reviewing.Reviewer checklist