fix: headless server no longer throws NPE on null configs #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
approved these changes
Dec 11, 2019
vcrfxia
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4114
Cause: #4114 (comment)
This other commit already fixes the problem by removing the config that was being set to null anyways.
2893241#diff-7848c43dbebc7bc8c45c12b2c1e2689cR247
This fix should still go in to prevent something like this from breaking headless mode again. Keys can't be null because the KsqlConfig would throw an exception if they weren't so we only need to check value.
Testing done
Spun up headless mode
Added a unit test
Reviewer checklist