fix: untracked file after cloning on Windows

[albertosantini]

Description

This patch resolves a problem on Windows.
After cloning the repo, git status shows one untracked file.

This is a due to the trailing period in the file name.

Fix #4023.

See also the the comments in the old PR #4046.

Testing done

I added and commit again the file.
Then I cloned again the repo and now it is ok.

Reviewer checklist

• Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
• Ensure relevant issues are linked (description should include text like "Fixes #")

[ghost]

@confluentinc It looks like @albertosantini just signed our Contributor License Agreement. 👍

Always at your service,

clabot

[big-andy-coates]

Thanks @albertosantini,

I appreciate you may simple not have the time to put a check in place to reject test names ending in a period.

Would you mind renaming the expected topology file as well, and adding that to the PR, and I can then merge...

Appreciate your input on this matter!

[albertosantini]

@big-andy-coates I am sorry for the partial PR.

My main point of pain (on Windows) is that file doesn't have any trailing period.
I verified with git bash and with cmd shell.

...
-rw-r--r-- 1 alberto.santini 1049089 2375 Dec 12 09:27  sink-partitions-replicas_-_Use_the_legacy_default_sink_properties_for_the_sink_topic_if_default_partitions_and_replicas_were_set
...

Basically I see that file as untracked.

Indeed I was wondering if I need to do some changes (renaming, for instance) to the actual file (that with the period); in this case I cannot do anything, because my git state is not coherent just after cloning.

Shall you help me, please?

About testing.
Fixing this on Windows it is only the first step, before building and testing as suggested in CONTRIBUTING doc. Indeed I have other problems for building and testing. See #4084.

[albertosantini]

I recovered a Linux box and I achieved to rename the expected topology file, removing the trailing period.

[big-andy-coates]

I recovered a Linux box and I achieved to rename the expected topology file, removing the trailing period.

Ah yes, of course you're going to have issues renaming a file you can't get on your filesystem. My bad!

Thanks for sorting. You're contribution is much appreciated!

[big-andy-coates]

LGTM

[albertosantini]

Tested. Forked and cloned again.

$ git clone [email protected]:albertosantini/ksql.git
Cloning into 'ksql'...
remote: Enumerating objects: 35, done.
remote: Counting objects: 100% (35/35), done.
remote: Compressing objects: 100% (31/31), done.
remote: Total 132597 (delta 9), reused 13 (delta 4), pack-reused 132562
Receiving objects: 100% (132597/132597), 38.44 MiB | 9.75 MiB/s, done.
Resolving deltas: 100% (69696/69696), done.
Updating files: 100% (2705/2705), done.
22:29:58 [/c/woot/var/my]
$ cd ksql
22:30:05 (master u=) [/c/woot/var/my/ksql]
$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
$ git log --oneline
04de30e74 (HEAD -> master, origin/master, origin/HEAD) fix: untracked file after cloning on Windows (#4122)
d5974e1c4 chore: fix join left right names (#4136)
4a6141a9d docs: add functions index to markdown docs (DOCS-3049) (#4135)
...

$ git --version
git version 2.24.1.windows.2

Perfect!