Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change query id generation to work with planned commands #4149

Merged
merged 2 commits into from
Dec 19, 2019
Merged

fix: change query id generation to work with planned commands #4149

merged 2 commits into from
Dec 19, 2019

Commits on Dec 16, 2019

  1. fix: change query id generation to work with planned commands 

    This patch changes up how we generate query IDs to play nice with
planned commands. Before this change, statements would get the current
offset as their query id. However planned commands get their query IDs
before being enqueued, so they should really get the _next_ expected
offset as their ID. This patch changes up the id generation to work
this way. The next ID is set _after_ statemetns/plans are executed,
and is set to the next expected offset.
    @rodesai
    rodesai committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    6d099ce View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Update ksql-rest-app/src/test/java/io/confluent/ksql/rest/server/comp… 

    …utation/InteractiveStatementExecutorTest.java

Co-Authored-By: Victoria Xia <[email protected]>
    @rodesai @vcrfxia
    rodesai and vcrfxia authored Dec 19, 2019
    Configuration menu
    Copy the full SHA
    a485e5c View commit details
    Browse the repository at this point in the history