Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for using --exec #425

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Add example for using --exec #425

merged 2 commits into from
Oct 30, 2017

Conversation

miguno
Copy link
Contributor

@miguno miguno commented Oct 30, 2017

No description provided.

@miguno
Copy link
Contributor Author

miguno commented Oct 30, 2017

See also #380.

@dguy
Copy link
Contributor

dguy commented Oct 30, 2017

@miguno can you raise this against the 4.0.x branch?

@miguno
Copy link
Contributor Author

miguno commented Oct 30, 2017

@dguy : I want to also raise against 4.0.x, but this should also go into the latest Dev Preview (0.1.x), no?

docs/examples.md Outdated

## Running KSQL

KSQL support various [modes of operation](concepts.md#modes-of-operation), including a standalone mode and a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KSQL supports...

docs/examples.md Outdated

Additionally, you can also instruct KSQL to execute a single statement from the command line.

Example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd move this text before the example, and consolidate a few things:
The following example runs a SELECT statement until 5 records have been found and then the results are shown in the terminal.

```shell
$ ksql-cli local --exec "SELECT * FROM pageviews LIMIT 5;"
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add an example of the expected output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed here IMHO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguno because it's self-explanatory, or?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it doesn't add anything to the answer. The question we want to answer is "how to run a single statement". The actual KSQL query as well as its output is irrelevant IMHO.

@miguno miguno merged commit 8020df0 into 0.1.x Oct 30, 2017
@miguno miguno deleted the 0.1.x-exec-docs branch October 30, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants