perf: Avoids logging INFO for rest-util requests, since it hurts pull query performance #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @AlanConfluent just signed our Contributor License Agreement. 👍 Always at your service, clabot |
|
@AlanConfluent can we file an issue as well and link it in the PR description.. using |
vinothchandar
approved these changes
Jan 14, 2020
config/log4j-rolling.properties
Outdated
| @@ -65,3 +65,6 @@ log4j.logger.processing=ERROR, kafka_appender | |||
| log4j.additivity.processing=false | |||
|
|
|||
| log4j.logger.org.reflections=ERROR, main | |||
|
|
|||
| # To acheive high throughput on pull queries, avoid logging every request from Jetty | |||
There was a problem hiding this comment.
Ahh, yes. Will fix.
AlanConfluent
force-pushed
the
dont_log_requests
branch
from
9d34685
to
014be85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids logging every request to come in at the Jetty level since that hurst pull query performance. Before this change, on my Mac, I was getting 14k qps and with this change, I'm getting 30k.
Fixes #4306
Testing done
Ran benchmarks.
Reviewer checklist