Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract QueryAnalyzer from QueryEngine #432

Merged
merged 1 commit into from
Nov 3, 2017
Merged

extract QueryAnalyzer from QueryEngine #432

merged 1 commit into from
Nov 3, 2017

Conversation

dguy
Copy link
Contributor

@dguy dguy commented Nov 2, 2017 •
edited
Loading

Extract QueryAnalyzer from QueryEngine.
Removed redundant usages of Optional from QuerySpecification

bluemonk3y
bluemonk3y approved these changes Nov 2, 2017
View reviewed changes
Copy link

@bluemonk3y bluemonk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hjafarpour
hjafarpour approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

apurvam
apurvam approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be worth mentioning that this patch also dropped redundant Optionals from the QuerySpecification

@dguy dguy merged commit 5da4c0e into confluentinc:4.0.x Nov 3, 2017
@dguy dguy deleted the query-engine branch November 3, 2017 09:32
TheRealHaui pushed a commit to TheRealHaui/ksql that referenced this pull request Nov 3, 2017
@dguy
extract QueryAnalyzer (confluentinc#432)
ef8967c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurvam apurvam apurvam approved these changes

@bluemonk3y bluemonk3y bluemonk3y approved these changes

@hjafarpour hjafarpour hjafarpour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dguy @apurvam @bluemonk3y @hjafarpour