Delimited integration test #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguy
reviewed
Nov 2, 2017
| private String topicName = "TestTopic"; | ||
| private TestDataProvider dataProvider; | ||
|
|
||
| String format = DataSource.DataSourceSerDe.DELIMITED.name(); |
|
|
||
| Map<String, GenericRow> expectedResults = Collections.singletonMap("ITEM_1", new GenericRow(Arrays.asList( "ITEM_1", "home cinema"))); | ||
|
|
||
| Map<String, GenericRow> results = testHarness.consumeData(testStreamName, dataProvider.schema(), 1, new StringDeserializer(), IntegrationTestHarness.RESULTS_POLL_MAX_TIME_MS); |
There was a problem hiding this comment.
Should we add retries here similar to what has been done in WindowingIntTest, i.e,
TestConditions.waitForCondition(() -> {
// return true if test condition satisfied
}, timeout, "failure message")
There was a problem hiding this comment.
Im not sure its needed - we aren't windowing/using a table, just pulling from a stream
There was a problem hiding this comment.
if it proves flakey I will add it in...
dguy
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#434 - to provide coverage and validation. Includes extending IntegrationTestHarness to support other Serdes