fix: support conversion of STRING to BIGINT for window bounds #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: confluentinc#4482 Comparison and Between expressions in the WHERE clause already support magic conversion from a STRING containing a ISO formatted datetime into a BIGINT for the `ROWTIME` column. This changes extends the support to cover the `WINDOWSTART` and `WINDOWEND` columns. The change also fixes a bug where by a numeric Between expression on `ROWTIME` resulted in a class-cast exception, e.g. `WHERE ROWTIME < 123546794894`.
agavra
approved these changes
Feb 10, 2020
.../src/main/java/io/confluent/ksql/engine/rewrite/StatementRewriteForMagicPseudoTimestamp.java
Show resolved
Hide resolved
ksql-functional-tests/src/test/resources/query-validation-tests/magic-timestamp-conversion.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #4482
Comparison and Between expressions in the WHERE clause already support magic conversion from a STRING containing a ISO formatted datetime into a BIGINT for the
ROWTIMEcolumn.This changes extends the support to cover the
WINDOWSTARTandWINDOWENDcolumns.The change also fixes a bug where by a numeric Between expression on
ROWTIMEresulted in a class-cast exception, e.g.WHERE ROWTIME < 123546794894.Testing done
tests added.
Reviewer checklist