Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print root cause in error message #4505

Merged

Conversation

stevenpyzhang
Copy link
Member

Description

Lost the root cause for an error during recent refactors. Using the ErrorMessageUtil.buildErrorMessage() to get back the specificity of the error message.

Testing done

before

ksql> CREATE STREAM KS_ORDERS WITH (KAFKA_TOPIC='KS_ORDERS', VALUE_FORMAT='AVRO');
Schema registry fetch for topic KS_ORDERS request failed.

after

ksql> CREATE STREAM KS_ORDERS WITH (KAFKA_TOPIC='KS_ORDERS', VALUE_FORMAT='AVRO');
Schema registry fetch for topic KS_ORDERS request failed.
Caused by: KSQL is not configured to use a schema registry. To enable it, please
        set ksql.schema.registry.url

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@stevenpyzhang stevenpyzhang requested a review from a team as a code owner February 10, 2020 18:44
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenpyzhang stevenpyzhang merged commit 6299410 into confluentinc:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants