Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ConcurrentModificationException in ClusterStatusResource #4510

Merged
merged 3 commits into from
Feb 11, 2020
Merged

fix: ConcurrentModificationException in ClusterStatusResource #4510

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c9df85
change stream api
vpapavas Feb 11, 2020
9102951
added unequal
vpapavas Feb 11, 2020
1a7ff98
fix compilation
vpapavas Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions ...rest-app/src/main/java/io/confluent/ksql/rest/server/resources/ClusterStatusResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
import io.confluent.ksql.rest.server.LagReportingAgent;
import io.confluent.ksql.util.HostStatus;
import io.confluent.ksql.util.KsqlHostInfo;
import io.confluent.ksql.util.PersistentQueryMetadata;
import java.util.HashMap;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
Expand Down Expand Up @@ -100,19 +102,24 @@ private HostStoreLags getHostStoreLags(final KsqlHostInfo ksqlHostInfo) {
private Map<String, ActiveStandbyEntity> getActiveStandbyInformation(
final KsqlHostInfo ksqlHostInfo
) {
return engine.getPersistentQueries().stream()
.flatMap(persistentQueryMetadata -> persistentQueryMetadata.getAllMetadata()
.stream()
.map(streamsMetadata -> new QueryIdAndStreamsMetadata(
persistentQueryMetadata.getQueryId().toString(), streamsMetadata)))
.filter(queryIdAndStreamsMetadata ->
queryIdAndStreamsMetadata.streamsMetadata != StreamsMetadata.NOT_AVAILABLE)
.filter(queryIdAndStreamsMetadata ->
queryIdAndStreamsMetadata.streamsMetadata.hostInfo().equals(asHostInfo(
ksqlHostInfo)))
.collect(Collectors.toMap(queryIdAndStreamsMetadata ->
queryIdAndStreamsMetadata.queryId ,
QueryIdAndStreamsMetadata::toActiveStandbyEntity));
Map<String, ActiveStandbyEntity> perQueryMap = new HashMap<>();
for (PersistentQueryMetadata persistentQueryMetadata: engine.getPersistentQueries()) {
for (StreamsMetadata streamsMetadata: persistentQueryMetadata.getAllMetadata()) {
if (streamsMetadata == StreamsMetadata.NOT_AVAILABLE
|| !streamsMetadata.hostInfo().equals(asHostInfo(ksqlHostInfo))) {
continue;
}
QueryIdAndStreamsMetadata queryIdAndStreamsMetadata = new QueryIdAndStreamsMetadata(
persistentQueryMetadata.getQueryId().toString(),
streamsMetadata
);
perQueryMap.putIfAbsent(
queryIdAndStreamsMetadata.queryId,
queryIdAndStreamsMetadata.toActiveStandbyEntity()
);
}
}
return perQueryMap;
}

private static final class QueryIdAndStreamsMetadata {
Expand Down