chore: remove Connect schema from Format interface #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this interface is moving towards being a pluggable public interface. Now, the `Format` interface deals with converting SchemaRegistry `ParsedSchema`s into the list of `SimpleColumn` ksql should use. Each `SimpleColumn` defines the name and type of the column. Conversion between connect and ksql types is now handled by the `ConnectFormat` base class. This base class currently converts all field names to uppercase. However, it is now possible for a format to return any-case names and those names will be respected.
agavra
approved these changes
Feb 26, 2020
ksql-serde/src/main/java/io/confluent/ksql/serde/connect/ConnectFormat.java
Show resolved
Hide resolved
ksql-serde/src/main/java/io/confluent/ksql/serde/connect/ConnectFormat.java
Outdated
Show resolved
Hide resolved
ksql-serde/src/main/java/io/confluent/ksql/serde/connect/ConnectFormat.java
Outdated
Show resolved
Hide resolved
Conflicting files ksql-functional-tests/src/main/java/io/confluent/ksql/test/tools/TestCaseBuilderUtil.java ksql-functional-tests/src/main/java/io/confluent/ksql/test/utils/SerdeUtil.java ksql-serde/src/main/java/io/confluent/ksql/serde/json/JsonFormat.java
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As this interface is moving towards being a pluggable public interface.
Now, the
Formatinterface deals with converting SchemaRegistryParsedSchemas into the list ofSimpleColumnksql should use. EachSimpleColumndefines the name and type of the column.Conversion between connect and ksql types is now handled by the
ConnectFormatbase class. This base class currently converts all field names to uppercase. However, it is now possible for a format to return any-case names and those names will be respected.Testing done
usual
Reviewer checklist