-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docs inline latest syntax changes #4686
Merged
big-andy-coates
merged 27 commits into
confluentinc:master
from
big-andy-coates:any_key_docs
Jun 23, 2020
Merged
docs: update docs inline latest syntax changes #4686
big-andy-coates
merged 27 commits into
confluentinc:master
from
big-andy-coates:any_key_docs
Jun 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
big-andy-coates
changed the title
docs: update inline with ability for arbitrary key column names
docs: update docs inline with ability for arbitrary key column names
Mar 18, 2020
2 tasks
big-andy-coates
changed the title
docs: update docs inline with ability for arbitrary key column names
docs: update docs inline latest syntax changes
Apr 24, 2020
2 tasks
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
reviewed
Jun 18, 2020
JimGalasyn
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great new content! LGTM, with a few suggestions. I'll cherry-pick to 6.0.x and 0.10.0-ksqldb.
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Bored of waiting for a second review. This is needed for the 0.10 / 6.0 release, so merging. @JimGalasyn are you OK to manage merging this to 6.0.x branch? |
JimGalasyn
added a commit
that referenced
this pull request
Jun 23, 2020
Including: * Any key name. * Removal of WITH(KEY) syntax. * Keyless streams * key columns required in projection * change in query semantics, i.e. KLIP-24 Co-authored-by: Andy Coates <[email protected]> Co-authored-by: Andy Coates <[email protected]> Co-authored-by: Andy Coates <[email protected]>
JimGalasyn
added a commit
that referenced
this pull request
Jun 24, 2020
Including: * Any key name. * Removal of WITH(KEY) syntax. * Keyless streams * key columns required in projection * change in query semantics, i.e. KLIP-24 Co-authored-by: Andy Coates <[email protected]> Co-authored-by: Andy Coates <[email protected]> Co-authored-by: Andy Coates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #4927
NEEDS MERGING TO 6.0.0
Update the docs inline with work to allow any arbitrary key column name, i.e. remove the restriction that key columns must be named
ROWKEY
.Doc change for PRs:
Testing done
Doc only change.
Reviewer checklist