Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs inline latest syntax changes #4686

Merged
merged 27 commits into from
Jun 23, 2020

Conversation

big-andy-coates
Copy link
Contributor

@big-andy-coates big-andy-coates commented Mar 3, 2020

Description

Fixes: #4927

NEEDS MERGING TO 6.0.0

Update the docs inline with work to allow any arbitrary key column name, i.e. remove the restriction that key columns must be named ROWKEY.

Doc change for PRs:

Testing done

Doc only change.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates changed the title docs: update inline with ability for arbitrary key column names docs: update docs inline with ability for arbitrary key column names Mar 18, 2020
@big-andy-coates big-andy-coates mentioned this pull request Apr 17, 2020
2 tasks
@big-andy-coates big-andy-coates changed the title docs: update docs inline with ability for arbitrary key column names docs: update docs inline latest syntax changes Apr 24, 2020
@big-andy-coates big-andy-coates added this to the 0.10.0 milestone Apr 24, 2020
@big-andy-coates big-andy-coates mentioned this pull request Apr 27, 2020
2 tasks
@big-andy-coates big-andy-coates marked this pull request as ready for review June 18, 2020 13:37
@big-andy-coates big-andy-coates requested review from JimGalasyn and a team as code owners June 18, 2020 13:37
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great new content! LGTM, with a few suggestions. I'll cherry-pick to 6.0.x and 0.10.0-ksqldb.

big-andy-coates and others added 19 commits June 18, 2020 20:46
@big-andy-coates
Copy link
Contributor Author

Bored of waiting for a second review. This is needed for the 0.10 / 6.0 release, so merging. @JimGalasyn are you OK to manage merging this to 6.0.x branch?

@big-andy-coates big-andy-coates merged commit 613d387 into confluentinc:master Jun 23, 2020
@big-andy-coates big-andy-coates deleted the any_key_docs branch June 23, 2020 20:45
JimGalasyn added a commit that referenced this pull request Jun 23, 2020
Including:
 * Any key name.
 * Removal of WITH(KEY) syntax.
 * Keyless streams
 * key columns required in projection
 * change in query semantics, i.e. KLIP-24

Co-authored-by: Andy Coates <[email protected]>

Co-authored-by: Andy Coates <[email protected]>
Co-authored-by: Andy Coates <[email protected]>
JimGalasyn added a commit that referenced this pull request Jun 24, 2020
Including:
 * Any key name.
 * Removal of WITH(KEY) syntax.
 * Keyless streams
 * key columns required in projection
 * change in query semantics, i.e. KLIP-24

Co-authored-by: Andy Coates <[email protected]>

Co-authored-by: Andy Coates <[email protected]>
Co-authored-by: Andy Coates <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update demos and examples for latest primitive key syntax
2 participants