feat: support for tunable retention, grace period for windowed tables #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @vinothchandar just signed our Contributor License Agreement. 👍 Always at your service, clabot |
vinothchandar
force-pushed
the
ksql-4157-tunable-retention
branch
3 times, most recently
from
bc6bc8d
to
810072c
Compare
vinothchandar
changed the title
vinothchandar
force-pushed
the
ksql-4157-tunable-retention
branch
2 times, most recently
from
091043e
to
65cde48
Compare
- Fixes confluentinc#4157, adding SQL syntax for specifying retention, grace period - Added functional tests feat: initial commit for tunable retention feat: hacky test now works
vinothchandar
force-pushed
the
ksql-4157-tunable-retention
branch
2 times, most recently
from
82dd65f
to
73c459c
Compare
|
Tests do pass locally.. On jenkins hitting some weird failures. Looking into them |
|
@JimGalasyn could you review the doc changes? |
vinothchandar
force-pushed
the
ksql-4157-tunable-retention
branch
2 times, most recently
from
77276c8
to
07035eb
Compare
JimGalasyn
reviewed
Mar 13, 2020
JimGalasyn
reviewed
Mar 13, 2020
JimGalasyn
reviewed
Mar 13, 2020
JimGalasyn
reviewed
Mar 13, 2020
JimGalasyn
reviewed
Mar 13, 2020
JimGalasyn
reviewed
Mar 13, 2020
JimGalasyn
reviewed
Mar 13, 2020
JimGalasyn
approved these changes
Mar 13, 2020
vinothchandar
force-pushed
the
ksql-4157-tunable-retention
branch
from
07035eb
to
1f367ac
Compare
|
Thanks @JimGalasyn ! Updated with the suggestions |
agavra
approved these changes
Mar 13, 2020
ksqldb-execution/src/main/java/io/confluent/ksql/execution/windows/WindowTimeClause.java
Show resolved
Hide resolved
...db-streams/src/test/java/io/confluent/ksql/execution/streams/StreamAggregateBuilderTest.java
Show resolved
Hide resolved
vinothchandar
force-pushed
the
ksql-4157-tunable-retention
branch
from
1f367ac
to
febc520
Compare
agavra
reviewed
Mar 13, 2020
...db-execution/src/main/java/io/confluent/ksql/execution/windows/TumblingWindowExpression.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both clauses are optional, and will fallback to Kafka streams defaults if unspecified.
Testing done
Reviewer checklist