Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better error code on shutdown #4754

Merged
merged 1 commit into from
Mar 18, 2020
Merged

fix: better error code on shutdown #4754

merged 1 commit into from
Mar 18, 2020

Conversation

rodesai
Copy link
Contributor

@rodesai rodesai commented Mar 11, 2020 •
edited
Loading

Description

Return a more specific error code on shutdown.

BREAKING CHANGE: return a 50303 in the error code msg (instead of 50300) for shutdown errors

@rodesai rodesai requested a review from a team as a code owner March 11, 2020 18:47
vcrfxia
vcrfxia approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm surprised there aren't failing unit/integration tests because of this change.

It's a backwards incompatible change so maybe worth calling it out with a quick "BREAKING CHANGE" line?

@rodesai rodesai force-pushed the set-specific-error-code-on-shutdown branch from 66bd340 to e8353eb Compare March 18, 2020 04:33
@rodesai rodesai merged commit 17d758d into confluentinc:master Mar 18, 2020
@rodesai rodesai deleted the set-specific-error-code-on-shutdown branch March 22, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodesai @vcrfxia